Define and implement the Incrementable trait for uints #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That will not work. You basically just create a different trait here. To achieve what you want to achieve, you need to implement the trait for these types in the crate where the trait is declared. It is also done for the other fundamental types there: https://github.com/paritytech/polkadot-sdk/blob/master/substrate/frame/support/src/traits/storage.rs#L282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Incrementable trait is defined in
frame-supportand only used in asset-conversion and nfts. This prevents types likeU256to be used in such pallets, which is particularly inconvenient when facing Ethereum compatibility.This PR redefines the
Incrementabletrait and implements it for uints, with the intention remove it fromframe-supportand use this one instead.